Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simplify namespace creation for helm deployment #365

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

bosesuneha
Copy link
Member

Description

This PR adds --create-namespace flag in the helm command to create a namespace if it does not exist.
The namespace.yaml file is removed from the templates folder as it is no longer needed.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bosesuneha bosesuneha marked this pull request as ready for review August 13, 2024 19:48
@bosesuneha bosesuneha merged commit ab1a1a7 into Azure:main Aug 13, 2024
148 checks passed
@bosesuneha bosesuneha deleted the update-workflow branch August 13, 2024 19:59
@bosesuneha bosesuneha mentioned this pull request Aug 13, 2024
14 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants