Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: add more traffic manager e2e tests #239

Merged
merged 2 commits into from
Dec 26, 2024
Merged

test: add more traffic manager e2e tests #239

merged 2 commits into from
Dec 26, 2024

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Dec 24, 2024

What type of PR is this?
/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

https://github.com/Azure/fleet-networking/actions/runs/12481424602

Special notes for your reviewer

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (153b55b) to head (f18e1e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   80.07%   79.78%   -0.29%     
==========================================
  Files          27       27              
  Lines        3844     3844              
==========================================
- Hits         3078     3067      -11     
- Misses        611      621      +10     
- Partials      155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiying-lin zhiying-lin force-pushed the set-e2e-env branch 2 times, most recently from f536370 to bb7773e Compare December 24, 2024 11:39
@zhiying-lin zhiying-lin requested a review from Copilot December 24, 2024 11:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • pkg/controllers/hub/trafficmanagerbackend/controller_integration_test.go: Evaluated as low risk
  • pkg/controllers/hub/trafficmanagerprofile/controller_integration_test.go: Evaluated as low risk
  • test/common/trafficmanager/azureprovider/profile.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/e2e/framework/workload_manager.go:206

  • The 'AddServiceDNSLabel' function should have a test case to ensure it works as expected.
func (wm *WorkloadManager) AddServiceDNSLabel(ctx context.Context, cluster *Cluster) error {

test/e2e/framework/workload_manager.go Outdated Show resolved Hide resolved
@jwtty jwtty merged commit 83b6427 into main Dec 26, 2024
14 of 15 checks passed
@zhiying-lin zhiying-lin deleted the set-e2e-env branch December 30, 2024 06:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants