Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upgrade dotnet versions #240

Merged
merged 3 commits into from
Jul 4, 2020
Merged

Upgrade dotnet versions #240

merged 3 commits into from
Jul 4, 2020

Conversation

Mandur
Copy link
Contributor

@Mandur Mandur commented Jul 3, 2020 •
edited
Loading

  • Upgrade .net 2.2 to 3.1
  • Upgrade function runtime to ~3
  • Use standard Arduino library for the CI

@Mandur Mandur added the fullci Run full continuous integration label Jul 3, 2020
@TechPreacher
Copy link
Contributor

Should we also update the .NET and dependencies versions in the \Samples and \Tools project folder?

@Mandur
Copy link
Contributor Author

Mandur commented Jul 3, 2020

Thanks for the suggestion @TechPreacher that sound like a lovely idea!

@Mandur
Copy link
Contributor Author

Mandur commented Jul 3, 2020

https://dev.azure.com/epicstuff/Azure%20IoT%20Edge%20LoRaWAN%20Starter%20Kit/_build/results?buildId=24621&view=logs&j=7826f347-8899-53d0-eafc-d3fbcaf988d6&t=b3b7d5bb-2197-57f0-8944-1e6878e9d878 All test worked except OTAAJoinTest

@TechPreacher
Copy link
Contributor

TechPreacher commented Jul 3, 2020 •
edited
Loading

Thanks for the suggestion @TechPreacher that sound like a lovely idea!

I'm happy to take this if you are short on time.

@Mandur
Copy link
Contributor Author

Mandur commented Jul 3, 2020

That would be great, Do you include it in another PR then?
OTAAJoinTest passed https://dev.azure.com/epicstuff/Azure%20IoT%20Edge%20LoRaWAN%20Starter%20Kit/_build/results?buildId=24622&view=logs&j=7826f347-8899-53d0-eafc-d3fbcaf988d6&t=7826f347-8899-53d0-eafc-d3fbcaf988d6

fbeltrao
fbeltrao approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@fbeltrao fbeltrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few suggestions. One thing we could think about is moving all the common used variables (target framework, unit test versions, etc) into a props file and reference it everywhere. This way modifying the used version is done in a single place and applied to all projects.

@Mandur Mandur self-assigned this Jul 3, 2020
@Mandur Mandur merged commit fdbc3c1 into dev Jul 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fbeltrao fbeltrao fbeltrao approved these changes

@TechPreacher TechPreacher TechPreacher approved these changes

@p-schuler p-schuler Awaiting requested review from p-schuler

Assignees

@Mandur Mandur

Labels
fullci Run full continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mandur @TechPreacher @fbeltrao