Fix missleading logs #260
Merged
Fix missleading logs #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand correctly the change is that we only validate if a RX2 was actually defined. Before, the log indicating invalid value would be written even if one was not set. |
fbeltrao
approved these changes
Sep 7, 2020
|
Do we have unit tests that cover the desired value being out of the limits? |
|
Yes in Check_Correct_RXPK_Datr_Are_Accepted and Check_incorrect_RXPK_Datr_Are_Refused in rxpktest.cs |
This was referenced Dec 20, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrong "the provided RX2DataRate is not valid" was displayed on the join logs in case a custom RX2DR is not set.