Add new ModuleRuntime::list_with_details
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the existing code used `ModuleRuntime::list` to list all modules, then called `Module::runtime_state` for each of them. This can fail if a module is deleted after it's returned in the `list` result and before its `runtime_state` is called. The new `list_with_details` API filters out those modules whose `runtime_state` fails with `NotFound`.
arsing
requested review from
myagley,
damonbarry and
avranju
and removed request for
myagley and
damonbarry
avranju
reviewed
Nov 1, 2018
| .map(|module| module.runtime_state().map(|state| (module, state))), | ||
| ) | ||
| }).flatten() | ||
| .then(Ok::<_, Error>) // Ok(_) -> Ok(Ok(_)), Err(_) -> Ok(Err(_)), ! -> Err(_) |
There was a problem hiding this comment.
Took a while for me to understand what's going on there! :)
avranju
approved these changes
Nov 1, 2018
|
I'd written the custom impl because I'd forgotten about the "lift with |
|
Ah. Got it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the existing code used
ModuleRuntime::listto list all modules,then called
Module::runtime_statefor each of them. This can fail if amodule is deleted after it's returned in the
listresult and beforeits
runtime_stateis called.The new
list_with_detailsAPI filters out those modules whoseruntime_statefails withNotFound.