Revert following commits as the original assumption where devicelogin… #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shouldn't work in non-interactive mode is invalid * Revert "Enable kubectl version lower than 1.22 to work though without triggering exit under devicelogin mode (Azure#152)" This reverts commit 9cfbe19. * Revert "Gaojing/devicelogin exit when interactivemode never (Azure#145)" This reverts commit 908abb3.
elim
added a commit
to elim/dotfiles
that referenced
this pull request
Aug 13, 2024
I need the kubelogin v0.0.24+, So I adopt the nixos-unstable version of kubelogin. > Was able to resolve this in windows by bumping kubelogin to v0.0.24+ > <https://github.com/Azure/kubelogin/releases/tag/v0.0.24> > > as they rolled back the device login commits: > [Azure/kubelogin#155](Azure/kubelogin#155) > [Azure/kubelogin#150](Azure/kubelogin#150) <lensapp/lens#6586 (comment)>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert following commits as the original assumption where devicelogin shouldn't work in non-interactive mode is invalid
Revert "Enable kubectl version lower than 1.22 to work though without triggering exit under devicelogin mode (Enable kubectl version lower than 1.22 to work though without triggering exit under devicelogin mode #152)" This reverts commit 9cfbe19.
Revert "Gaojing/devicelogin exit when interactivemode never (Gaojing/devicelogin exit when interactivemode never #145)" This reverts commit 908abb3.