Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/addtests #238

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Feature/addtests #238

merged 4 commits into from
Apr 6, 2023

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Mar 24, 2023

This PR intends to add more test with intention of catering low hanging fruits of capturing failure case tests and hence increasing the test coverage to almost 50% for this repo.

I have used direct calls and no mocks are involved so the correct logic can be test.

Thank yo use much in advance. ❤️🙏 Kind ping as fyi @weinong

@Tatsinnit Tatsinnit self-assigned this Mar 24, 2023
@Tatsinnit Tatsinnit requested a review from weinong March 24, 2023 05:30
@Tatsinnit Tatsinnit added the enhancement New feature or request label Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #238 (a8c14d4) into master (92510eb) will increase coverage by 5.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   44.34%   49.72%   +5.38%     
==========================================
  Files          15       15              
  Lines        1096     1096              
==========================================
+ Hits          486      545      +59     
+ Misses        577      520      -57     
+ Partials       33       31       -2     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize for missing this PR. LGTM.

@weinong weinong merged commit b4a5938 into Azure:master Apr 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants