Adding installHint field to kubeconfigs that have been converted to the exec format #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinong
reviewed
May 18, 2023
weinong
reviewed
May 19, 2023
weinong
reviewed
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 53.48% 53.68% +0.20%
==========================================
Files 15 15
Lines 1120 1125 +5
==========================================
+ Hits 599 604 +5
Misses 488 488
Partials 33 33
|
weinong
reviewed
May 25, 2023
pkg/converter/convert.go
Outdated
| execInstallHint = ` | ||
| kubelogin is not installed which is required to connect to AAD enabled cluster. | ||
|
|
||
| To learn more, please go to https://aka.ms/aks/kubelogin |
There was a problem hiding this comment.
let's use https://azure.github.io/kubelogin/
weinong
reviewed
May 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallHint field tells users how to install the binary in the command field if it isn't present in their PATH.
We need to add this field to any kubeconfig that gets converted since it can be transported to another machine/environment that does not have kubelogin installed.