Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[library usage] Implement library token provider #380

Merged
merged 7 commits into from
Dec 20, 2023
Merged

[library usage] Implement library token provider #380

merged 7 commits into from
Dec 20, 2023

Conversation

bcho
Copy link
Member

@bcho bcho commented Dec 19, 2023

This pull request is part of the changes for #373

In this pull request, we implemented the library token provider instance and options settings. To allow reusing the environment variables, we introduced a new package internal/env for holding all environment variables.

Base automatically changed from internal-token-type to master December 20, 2023 02:14
@bcho bcho marked this pull request as ready for review December 20, 2023 02:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7564350) 64.26% compared to head (aef75af) 65.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   64.26%   65.46%   +1.20%     
==========================================
  Files          25       27       +2     
  Lines        1830     1894      +64     
==========================================
+ Hits         1176     1240      +64     
  Misses        579      579              
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment.

@bcho bcho merged commit 30ead78 into master Dec 20, 2023
6 checks passed
@bcho bcho deleted the pkg-token branch December 20, 2023 02:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants