Custom HttpClient not used for every call to the service

[bgavrilMS]

Which Version of ADAL are you using ?
4.5

Which platform has the issue?
all

Repro
Use the new AuthenticationContext constructor that takes in an HttpClient. Some flows use a new HttpClient everytime.

Expected behavior
the passed in httpclient should be used everywhere

Actual behavior
the httpClient is not used in some calls, such as the auth code request.
the custom httpClient is used for calls to the MEX endpoint.

Note: this is where we create a new HttpClient https://github.com:443/AzureAD/azure-activedirectory-library-for-dotnet.git/blob/dev/src/Microsoft.IdentityModel.Clients.ActiveDirectory/Internal/Http/HttpClientWrapper.cs#L66
This is also bad for perf, because we should reuse this httpClient.

[GroupeElanz]

Same issue here.
Using a proxy is mandatory for us, so we use a custom HttpClient to specify the proxy (as described here: https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/wiki/with-proxy) but not all the calls use this proxy.
Is there a workaround except setting a proxy at system level?

[bgavrilMS]

Yes, could you try to use the WebRequest.defaultwebproxy described in the same wiki page in the last paragraph? Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: GroupeElanz <notifications@github.com> Sent: Wednesday, February 13, 2019 7:56:07 PM To: AzureAD/azure-activedirectory-library-for-dotnet Cc: Bogdan Gavril; Author Subject: Re: [AzureAD/azure-activedirectory-library-for-dotnet] Custom HttpClient not used for every call to the service (#1488) Same issue here. Using a proxy is mandatory for us, so we use a custom HttpClient to specify the proxy (as described here: https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/wiki/with-proxy<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2FAzureAD%2Fazure-activedirectory-library-for-dotnet%2Fwiki%2Fwith-proxy&data=02%7C01%7CBogdan.Gavril%40microsoft.com%7Cd01161750adc431c0f8708d691b29efc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856593687810115&sdata=%2F4ov2zsTt8yA5bfk12m5O72HZU665ImS1Th%2BjW4Rw2w%3D&reserved=0>) but not all the calls use this proxy. Is there a workaround except setting a proxy at system level? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2FAzureAD%2Fazure-activedirectory-library-for-dotnet%2Fissues%2F1488%23issuecomment-463189020&data=02%7C01%7CBogdan.Gavril%40microsoft.com%7Cd01161750adc431c0f8708d691b29efc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856593687820124&sdata=1t%2BdjO1U5cgO1GQ%2BI3WbPHYRzyoFgH%2BQ5Q%2FqBewpWdU%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2Fnotifications%2Funsubscribe-auth%2FALtG6LfK1lhseav1A6txhwzyVIwFBJJmks5vNAtngaJpZM4aRa0i&data=02%7C01%7CBogdan.Gavril%40microsoft.com%7Cd01161750adc431c0f8708d691b29efc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856593687830132&sdata=nmnxlOZnfUOGuoSSxcId7L69oYwhg2f4thHivyyEHiA%3D&reserved=0>.

[GroupeElanz]

Hello, this works and that's the same behavior as setting the proxy on web.config, but our customer wants to isolate only the ADAL calls through a specific proxy with specific credentials.

[nikitinvalera]

Hi Bogdan,
WebRequest.defaultwebproxy will not help for .NET core project, so I wonder if ALL Handlers (like AcquireTokenForClientHandler) will ever (will they?) use custom configured HttpClient?

This is a problem for us, since we're behind corporate firewall.

[GroupeElanz]

Hello,
Is there already a planned date for the release of a version which includes the correction?

[javisst]

Hi, we are also behind a corporate proxy and very interested in a solution to that.

[bgavrilMS]

This is being actively worked on.

[vadirajgk]

We are also facing same issue in our test server, I think ADAL API is not allowing it to read the proxy values passed in the HttpClient object for the AuthenticationContext call. It will work fine when we add proxy in IE for that user account login only but we can not do this. Also we can not add proxy on system level.

Please let us know the ETA for this. This is impacting by holding the multiple application's production release from one month.

[henrik-me]

PR: #1530

[zapalap]

It looks like the custom IHttpClientFactory passed to the new AuthenticationContext constructor is not actually used further.

It's because of this code:

azure-activedirectory-library-for-dotnet/src/Microsoft.IdentityModel.Clients.ActiveDirectory/Core/ServiceBundle.cs

Lines 70 to 80 in c66dc64

	internal static IServiceBundle CreateWithHttpClientFactory(IHttpClientFactory httpClientFactory)
	{
	if (httpClientFactory != null)
	{
	return new ServiceBundle(new HttpClientFactory());
	}
	else
	{
	return new ServiceBundle();
	}
	}

So even if the httpClientFactory parameter is not null it's not being passed to the ServiceBundle constructor.

[jennyf19]

@zapalap this has been fixed and will be in 5.0.1-preview release. fix is merged into dev. thank you.

[jennyf19]

included in ADAL 5.0.1-preview