Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

WebBrowser state messages go directly to Trace. #150

Closed
christav opened this issue Jan 16, 2015 · 2 comments
Closed

WebBrowser state messages go directly to Trace. #150

christav opened this issue Jan 16, 2015 · 2 comments

Comments

@christav
Copy link

In WindowsFormsWebAuthenticationDialogBase.cs, line 191, there's a call to output diagnostic information that uses Trace.WriteLine. When using ADAL in a console app, this results in extra useless logging junk all over my console output. Trace.WriteLine is for apps, not for libraries.

Put this logging behind a TraceSwitch so it can be turned off like you've done in the main ADAL library.
afshins pushed a commit that referenced this issue Feb 16, 2015
Fixing issues #150 and #155
aa221a9 
#150: WebBrowser state messages go directly to Trace.
#155: Add logging to trace the visited urls in authorization flow
afshins pushed a commit that referenced this issue Feb 17, 2015
Fixing issues #150 and #155 in v3
0914596 
#150: WebBrowser state messages go directly to Trace.
#155: Add logging to trace the visited urls in authorization flow
@afshins
Copy link
Contributor

afshins commented Feb 17, 2015

Fixed.

@afshins afshins closed this as completed Feb 17, 2015
@afshins
Copy link
Contributor

afshins commented Apr 15, 2015

@christav the fix is now released.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christav @afshins