Fix for #1750 - Hardcode tenant and authorize endpoints instead of OI… #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
reviewed
May 14, 2020
jennyf19
reviewed
May 14, 2020
jennyf19
reviewed
May 14, 2020
| /// <summary> | ||
| /// Gets the authority endpoints based on the host and tenant id. Does not rely on OIDC discovery. | ||
| /// </summary> | ||
| internal abstract AuthorityEndpoints GetHardcodedEndpoints(); |
There was a problem hiding this comment.
nit: just for discussion...these are actually the authorization server endpoints...Does it make sense to call them what they are, verse authority endpoints? just seems confusing. really just a discussion point here.
There was a problem hiding this comment.
Happy to rename them, but maybe not Authorization endpoints because "authoirzation endpoint" is one of them. Myabe OAuth2Endpoints?
There was a problem hiding this comment.
OAuth2Endpoints make sense.
jennyf19
reviewed
May 14, 2020
| { | ||
| AuthorizationEndpoint = authorizationEndpoint; | ||
| TokenEndpoint = tokenEndpoint; | ||
| SelfSignedJwtAudience = selfSignedJwtAudience; | ||
| SelfSignedJwtAudience = tokenEndpoint; |
There was a problem hiding this comment.
this is the tokenEndpoint?
jennyf19
reviewed
May 14, 2020
jennyf19
reviewed
May 14, 2020
| TokenEndpointTemplate, | ||
| AuthorityInfo.CanonicalAuthority); | ||
|
|
||
| string authEndpoint = string.Format(CultureInfo.InvariantCulture, |
There was a problem hiding this comment.
authEndpoint [](start = 19, length = 12)
nit: call this authorizationEndpoint
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DC discovery