Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding support for Service principasl on OBO #2506

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Adding support for Service principasl on OBO #2506

merged 4 commits into from
Mar 25, 2021

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Mar 24, 2021

Fix for #1845

jmprieur
jmprieur approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trwalke
LGTM

Given the very specifics of the app registration don't we want to add a comment in the test, pointing to an internal page explaining the end to end ?

@trwalke trwalke merged commit 0ede7ce into master Mar 25, 2021
@trwalke trwalke deleted the trwalke/OBOforSP branch March 25, 2021 16:34
@trwalke trwalke restored the trwalke/OBOforSP branch March 26, 2021 17:47
@trwalke trwalke deleted the trwalke/OBOforSP branch June 22, 2021 21:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@bgavrilMS bgavrilMS bgavrilMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trwalke @bgavrilMS @jmprieur