msal-node e2e tests: cert_path -> certificate_path #7357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
tnorling,
sameerag,
jo-arroyo,
hectormmg,
lalimasharda,
peterzenz,
bgavrilMS,
konstantin-msft and
shylasummers
as code owners
Robbie-Microsoft
commented
Oct 2, 2024
|
Can you rename your branch so it's the same as the 1P branch? Otherwise the pipelines will not checkout the right code. |
Robbie-Microsoft
commented
Oct 3, 2024
bgavrilMS
reviewed
Oct 3, 2024
bgavrilMS
approved these changes
Oct 3, 2024
konstantin-msft
approved these changes
Oct 3, 2024
tnorling
approved these changes
Oct 3, 2024
Robbie-Microsoft
commented
Oct 3, 2024
sameerag
approved these changes
Oct 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@azure/identity's
new DefaultAzureCredential()expectsAZURE_CLIENT_CERTIFICATE_PATHinstead ofAZURE_CLIENT_CERT_PATH.Corresponding 1-P PR