Rethrow MSAL AuthErrors in NAA flow #7559
Merged
+83
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAA flow catches errors and runs them through
fromBridgeError
, but not all errors in thetry
come from the bridge. Notably,fromNaaTokenResponse
can throw aClientAuthError
if a token is empty, and cache codepaths can throw someCacheError
s.This PR ensures that if an error is already an MSAL
AuthError
, it does not get passed throughfromBridgeError
again and converted into anunknown_error
.