Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MSAL - Implement E2E automation tests for the device registration upgrade #2377

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

antonioalwan
Copy link
Contributor

Proposed changes

Update Identity core to include automation changes

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Related to WI: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3052698

@antonioalwan antonioalwan requested a review from a team as a code owner November 4, 2024 20:19
@juan-arias
Copy link
Member

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@@ -1 +1 @@
Subproject commit b4fd324d200caef614635cecb4c0ac66c413e23f

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@ameyapat
Copy link
Contributor

ameyapat commented Nov 5, 2024

Cloned PR for antonioalwan/12_add_automation_wpj_token_binding


AI description (iteration 1)

PR Classification

Bug fix and new feature addition.

PR Summary

This pull request addresses a bug related to the timing of request completion block assignments and adds support for secure enclave in WPJ automation tests.

  • MSIDSSOExtensionGetAccountsRequest.m, MSIDSSOExtensionGetDeviceInfoRequest.m, MSIDSSOExtensionInteractiveTokenRequest.m, MSIDSSOExtensionSignoutRequest.m, MSIDSSOExtensionSilentTokenRequest.m: Fixed the order of setting the request completion block and performing requests.
  • MSIDAutomationTestRequest.h, MSIDAutomationTestRequest.m: Added a new property isSecureEnclaveSupportedForWpj to support secure enclave in WPJ.
  • MSIDTestAutomationAccountConfigurationRequest.h, MSIDTestAutomationAccountConfigurationRequest.m: Added a new account protection policy type MSIDTestAccountProtectionPolicyTypeTB for token binding.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants