-
Notifications
You must be signed in to change notification settings - Fork 206
Prefer Edge when running on Linux #388
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
38dd226
to
449c250
Compare
Before this PR, MSAL would always launch the default browser. After this PR, MSAL would launch Edge browser when running on Linux and when Edge is available. Here we document the different user experience of the two approaches when end user is on Linux and potentially accessing resources that are protected by device-based Conditional Access (CA) policy.
UPDATE: We ended up using the second bullet point's approach. |
First attempt was by using BROWSER env var Switch to less intrusive register(browser_name...) Only perform webbrowse.register() when necessary Explain design decisions based on PR review Q&A
2d0894d
to
f565493
Compare
I know this is long done and gone but my issue was the last one linked so I wanted to comment. IMHO I found this unfortunate that you took away the Linux Users choice of default browser. This has led me to remove Edge from my system and will not be re-introduced. |
Fair enough. In case you want to try Edge again but want to have MSAL Python (thus Azure CLI) honor your default browser, you can set an env var |
Why is the standard browser explicitly ignored and instead it opens edge? This is totally unexpected Behaviour. Why do you not accept my decision on not making edge the standard browser? |
Edge will soon become the first browser on Linux to support device-based conditional access policy. This PR has MSAL to prefer using Edge for
acquire_token_interactive()
.How to test this feature?
pip install git+https://github.com/AzureAD/microsoft-authentication-library-for-python.git@prefer-edge-on-linux
.python interactive_sample.py config.json
:@chlowell @jiasli Please help review this feature.