Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug] throw an ArgumentException if tenant is 'common' or 'organizations' for acquire token for app scenarios #793

Closed
jennyf19 opened this issue Nov 30, 2020 · 3 comments · Fixed by #795
Closed

[Bug] throw an ArgumentException if tenant is 'common' or 'organizations' for acquire token for app scenarios #793

jennyf19 opened this issue Nov 30, 2020 · 3 comments · Fixed by #795
Labels
bug Something isn't working fixed P2
Milestone
1.4.0

Comments

@jennyf19
Copy link
Collaborator

see #790 for details.
@jennyf19 jennyf19 added this to the 1.4.0 milestone Nov 30, 2020
hajekj added a commit to hajekj/microsoft-identity-web that referenced this issue Dec 1, 2020
@hajekj
Add Common tenant to meta tenant identifiers and check for TenantId n…
8b61888 
…ot to match when obtaining token via client_credentials flow.

Fixes AzureAD#793
@hajekj hajekj mentioned this issue Dec 1, 2020
Merged
@jmprieur jmprieur added bug Something isn't working P2 labels Dec 1, 2020
@jmprieur jmprieur assigned jennyf19 and unassigned jennyf19 Dec 1, 2020
jennyf19 pushed a commit that referenced this issue Dec 2, 2020
@hajekj
Throw an ArgumentException if tenant is 'common' or 'organizations' f…
d566dca 
…or acquire token for app scenarios (#795)

* Add support for tenant selection when using AppOnly Microsoft Graph.

* Add Common tenant to meta tenant identifiers and check for TenantId not to match when obtaining token via client_credentials flow.

Fixes #793

* Allow client_credentials to function with consumers endpoint.

* Explicitly provide tenantId from configuration if not specified when obtaining token via client_credentials. Streamline argument validation.
@jennyf19 jennyf19 added fixed and removed In progress labels Dec 2, 2020
@jennyf19
Copy link
Collaborator Author

jennyf19 commented Dec 2, 2020

fixed by PR from @hajekj

@jennyf19
Copy link
Collaborator Author

jennyf19 commented Dec 2, 2020

auto-magically closed when PR was merged, reopening until we release. cc: @jmprieur

@jennyf19 jennyf19 reopened this Dec 2, 2020
@jennyf19
Copy link
Collaborator Author

jennyf19 commented Dec 9, 2020

thanks for your work on this one @hajekj
Included in 1.4 Release.

@jennyf19 jennyf19 closed this as completed Dec 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed P2
Projects
None yet
Milestone
1.4.0
2 participants
@jmprieur @jennyf19