Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert: Warning Quality Check Build Task #3172

Merged

Conversation

alexholub113
Copy link
Contributor

since these changes cause errors in the pipeline it was decided to roll them back temporarily

@alexholub113 alexholub113 requested a review from a team as a code owner January 2, 2025 17:29
@keegan-caruso
Copy link
Contributor

@alexholub113 Can you link to the pipeline that is now passing with this reverted?

@TimHannMSFT
Copy link

@alexholub113 I suspect you'll have to edit the pipeline for now to target your branch and ensure this fixes as expected I've shared more details in our internal channel. Once there's a passing pipeline run there I'll approve.

In the fullness of time we should have that pipeline take a parameter for branch and then have IDWeb PRs run that pipeline as a merge gate

@alexholub113
Copy link
Contributor Author

To test this revert I created OneBranch PR.
The OneBranch-PullRequest pipeline was successfully passed.

Copy link

@TimHannMSFT TimHannMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexholub113 !

Please create a PBI and assign to @kellyyangsong to re-add this check once it no longer breaks the onebranch PR build

@alexholub113
Copy link
Contributor Author

Task was created

Copy link
Contributor

@FuPingFranco FuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexholub113 alexholub113 merged commit 8563cf9 into master Jan 2, 2025
5 checks passed
@alexholub113 alexholub113 deleted the alexholub/revert-warning-quality-check-build-task branch January 2, 2025 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants