Simplification of the token cache serialization providers #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t need a reference to the options (the ClientId, which was extracted from these options, can be provided by the TokenCacheArguments, or in the call ClearAsync
…t need a reference to the options (the ClientId, which was extracted from these options, can be provided by the TokenCacheArguments, or in the call ClearAsync
…github.com/AzureAD/microsoft-identity-web into jmprieur/removeOptionsFromCacheSerializers
pmaytak
reviewed
Mar 30, 2020
| @@ -22,6 +22,6 @@ public interface IMsalTokenCacheProvider | |||
| /// Clear the cache | |||
| /// </summary> | |||
| /// <returns></returns> | |||
| Task ClearAsync(); | |||
| Task ClearAsync(string clientId); | |||
There was a problem hiding this comment.
Should we also update the comments or will there be a task to go over all of the comments in the project?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification of the token cache serialization providers, which don't need a reference to the options (the ClientId, which was extracted from these options, can be provided by the TokenCacheArguments, or in the call ClearAsync