Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix login/domain hint constant #800

Merged
merged 1 commit into from
Dec 2, 2020
Merged

fix login/domain hint constant #800

merged 1 commit into from
Dec 2, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Dec 2, 2020

@jennyf19 jennyf19 requested a review from jmprieur December 2, 2020 17:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jmprieur
jmprieur approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

@jennyf19 jennyf19 merged commit 8fa27af into master Dec 2, 2020
@jennyf19 jennyf19 deleted the jennyf/fixConstants branch December 2, 2020 17:51
@jmprieur jmprieur mentioned this pull request Dec 5, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur