-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/#371 학습자료 상세 조회 에러 처리 #377
Open
yeonddori
wants to merge
9
commits into
develop
Choose a base branch
from
Feature/#371-학습자료_상세_조회_에러_처리
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "Feature/#371-\uD559\uC2B5\uC790\uB8CC_\uC0C1\uC138_\uC870\uD68C_\uC5D0\uB7EC_\uCC98\uB9AC"
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llddang
requested changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…into Feature/#371-학습자료_상세_조회_에러_처리
e88f993
to
e167933
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
=> 확인해본 결과, Application error는 뜨지 않았습니다. 그래도 다들 확인 부탁드립니다!
리뷰 요구 사항
AlertModal
을 활용해 표시했습니다. 하지만 이제 생각해보니, 스터디 카드의 진행 상태처럼 작은 Badge 형태로 '로그인 필요', '팀원만 가능' 등의 메시지를 표시하는 것도 괜찮아 보이네요.. 하지만 클릭했을 때 아무 반응이 없으면 또 이상할 것 같기도 하고.. 너무 어렵네요😵💫 지금 구현한 모달 알림창 형식은 다들 괜찮으신지 의견 부탁드립니다!미리 보기