Fix: mass_prior_weights uninitialized #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mass_prior_weights was not initialized in the 'else' section, en then used in the for loop below this part of code. Set to np.zeros(1) as a fix.
|
Good catch. |
galaxyumi
pushed a commit
to galaxyumi/beast
that referenced
this pull request
Jun 7, 2020
Fix: mass_prior_weights uninitialized
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around a bit and came across this bug.
mass_prior_weights is not initialized in the 'else' section of the 'if' block. It is then used in the for loop below it. If the 'else' section is entered the first time the 'if' block is evaluated, this leaves mass_prior_weights uninitialized, crashing the program with an error.
Fix suggested: Set to np.zeros(1), just like mass_grid_weights. Would this produce correct behaviour?