Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Modoc] Jo only gives discount once #212

Closed
phobos2077 opened this issue Jul 9, 2023 · 4 comments · Fixed by #222
Closed

[Modoc] Jo only gives discount once #212

phobos2077 opened this issue Jul 9, 2023 · 4 comments · Fixed by #222
Assignees

Comments

@phobos2077
Copy link

What happened

After completing the Ghost Farm quest (the best solution), Jo says he'll give a discount. But it only applies immediately during the same dialog. If you talk afterwards, he will "forget" about it.

What you expected to happen

Like most other character, gdialog_set_barter_mod must be called in talk_p_proc depending on quest status (or some lvar flag) so he actually keeps his word.

@phobos2077
Copy link
Author

Fixed here: b2bca23

@burner1024
Copy link
Member

Isn't it the same with Renesco? Why do you think it should be remembered?

@phobos2077
Copy link
Author

phobos2077 commented Jul 10, 2023

Isn't it the same with Renesco? Why do you think it should be remembered?

Why not? He thanks you for saving the town from famine and says he'll supply you "at basically my cost".

This is for -75% case (note that it also "unlocks" the shelves in the current script, basically making his stock free of charge):

I wish I had more I could give you, but we're still a poor community with not
much in the way of offerings. The best I can do is offer you goods at basically my cost. But
I'd be honored to help keep you stocked for your journeys when I have the goods and I'm sure any
of the other residents would be equally grateful if you asked them.

This is -50% case:

I wish I could give you more in the way of compensation than this,
but the best I can offer you is a discount on goods. I'm not too stocked up right now, but I'm
sure things will pick up around here soon and I'd be honored to help stock you up.

@burner1024
Copy link
Member

Makes sense.

burner1024 pushed a commit that referenced this issue Aug 1, 2023
- And fix dialog enter copypasta
NovaRain pushed a commit that referenced this issue Apr 19, 2024
- And fix dialog enter copypasta
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants