Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Diffing_Engine: IsEqual could avoid comparing all properties in case of same object being provided on both hand sides #3427

Closed
pawelbaran opened this issue Nov 4, 2024 · 0 comments · Fixed by #3428
Closed

Diffing_Engine: IsEqual could avoid comparing all properties in case of same object being provided on both hand sides #3427

pawelbaran opened this issue Nov 4, 2024 · 0 comments · Fixed by #3428
Assignees
@pawelbaran
Labels
type:feature New capability or enhancement

Comments

@pawelbaran
Copy link
Member

Description:

Simple implementation, add if (obj1 == obj2) before getting into type and property comparison.

@alelom
@pawelbaran pawelbaran added the type:feature New capability or enhancement label Nov 4, 2024
@pawelbaran pawelbaran self-assigned this Nov 4, 2024
@pawelbaran pawelbaran mentioned this issue Nov 4, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pawelbaran pawelbaran

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diffing_Engine: Performance of IsEqual improved BHoM/BHoM_Engine
1 participant
@pawelbaran