Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Diffing_Engine: Performance of IsEqual improved #3428

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #3427

Test files

DiffingTests_Prototypes

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Nov 4, 2024
@pawelbaran pawelbaran self-assigned this Nov 4, 2024
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with DiffingTests_Prototypes, and reviewed code. Agreed with @pawelbaran on a call that this is an improvement and doesn't affect the BaseComparisonConfig functionality.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 22 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Nov 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Nov 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

There are 20 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 68ea962 into develop Nov 5, 2024
13 checks passed
@pawelbaran pawelbaran deleted the BHoM_Engine-#3427-OptimiseIsEqual branch November 5, 2024 12:00
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:feature New capability or enhancement
Projects
None yet
2 participants