-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Diffing_Engine: Do not include static properties and fields in differences #3410
Diffing_Engine: Do not include static properties and fields in differences #3410
Conversation
a bit of half unrelated clean-up. Found these while searching for places where kellerman was being used, to ensure the config change was not required elsewhere, and thought I might as well remove the unused using's while I found them. Not the only file that has a reference to kellerman is ObjectDifferences.cs.
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check serialisation |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3406
Rule out static properties from inclusion in comparison. (see issue for a bit more detail).
Minor cleanup of unused using's.
This reinstates the behaviour for testing prior to this:
BHoM/Test_Toolkit#474
Test files
Check unit-tests. This should give a not insignificant improvement in speed for running through them, especially for tests containing System.Drawing.Color.
Also, @alelom , great if you can test this through your diffing tests.
Changelog
Additional comments
Example run before this PR:
https://github.com/BHoM/BHoM_Engine/runs/29579805351