Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Verification_Engine - Report Message null checks added #3433

Merged

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3432

Added null checks to ReportMessage public method.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Dec 2, 2024
@michal-pekacki michal-pekacki self-assigned this Dec 2, 2024
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense, happy to approve

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 2, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 2, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

@pawelbaran pawelbaran merged commit b97deef into develop Dec 2, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Verification_Engine-#3432-ReportMessageNullCheck branch December 2, 2024 14:27
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification_Engine: Report Message missing null check
2 participants