Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

plot_windmatrix fails if source == None #276

Closed
jamesramsden-bh opened this issue Dec 6, 2024 · 0 comments · Fixed by #279
Closed

plot_windmatrix fails if source == None #276

jamesramsden-bh opened this issue Dec 6, 2024 · 0 comments · Fixed by #279
Assignees
Labels
good first issue Good for newcomers size:S Measured in minutes type:bug Error or unexpected behaviour

Comments

@jamesramsden-bh
Copy link
Contributor

It is possible to create a Wind object with the source unset, in which case it defaults to None. This is not an issue in itself, but plot_windmatrix fails if self.source == None, as line 1679 attempts to append to a string:

        title = self.source
        title += f'\n{kwargs.pop("title", None)}'

Please ensure that NoneType is handled when creating the plot title here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants