-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Handle NoneType in plot_windmatrix to Prevent Errors #279
Handle NoneType in plot_windmatrix to Prevent Errors #279
Conversation
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good now, and running windmatrix without a source no longer produces errors.
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #276
plot_windmatrix failed if self.source == None.
Added a if-loop to handle the NoneType in plot_windmatrix to prevent errors when creating the plot title.
Test files
run python automated testing batch file
Changelog
Additional comments