Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle NoneType in plot_windmatrix to Prevent Errors #279

Merged

Conversation

msandmer
Copy link
Contributor

@msandmer msandmer commented Dec 6, 2024

Issues addressed by this PR

Closes #276

plot_windmatrix failed if self.source == None.
Added a if-loop to handle the NoneType in plot_windmatrix to prevent errors when creating the plot title.

Test files

run python automated testing batch file

Changelog

Additional comments

@msandmer msandmer added good first issue Good for newcomers type:bug Error or unexpected behaviour labels Dec 6, 2024
@msandmer msandmer self-assigned this Dec 6, 2024
msandmer and others added 2 commits December 9, 2024 15:55
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now, and running windmatrix without a source no longer produces errors.

@Tom-Kingstone
Copy link
Contributor

Tom-Kingstone commented Dec 10, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

There are 9 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Dec 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit 1fdf3c8 into develop Dec 11, 2024
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#276-WindmatrixPlotNoneType branch December 11, 2024 11:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_windmatrix fails if source == None
3 participants