-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move base plots to Python_Toolkit #268
Conversation
@Tom-Kingstone just to let you know, I have provided a |
1 similar comment
@Tom-Kingstone just to let you know, I have provided a |
@Tom-Kingstone just to let you know, I have provided a |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 37 requests in the queue ahead of you. |
524e6a1
to
b8f9d09
Compare
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with unit tests plus some self spot checks. No critical issues preventing merge. Any non-critical issues should have issues raised separately.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
The check |
@Tom-Kingstone just to let you know, I have provided a |
@BHoMBot check compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
NOTE: Depends on BHoM/Python_Toolkit#147
Issues addressed by this PR
Closes #206
Base plots and helper/utility methods have been moved to Python_Toolkit (see the linked PR at the top)
References to python_toolkit have been made where utility and helper methods have been moved, so that the rest of the toolkit and any user scripts do not break, though plots marked private that were moved will have been updated to
python_toolkit.plot.<name-of-plot>
and no longer marked as private.e.g.
from ladybugtools_toolkit.plot._heatmap import heatmap
would become
from python_toolkit.plot.heatmap import heatmap
Test files
run the python unit tests to check that nothing is broken.
Changelog
Additional comments