Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move base plots to Python_Toolkit #268

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Nov 12, 2024

NOTE: Depends on BHoM/Python_Toolkit#147

Issues addressed by this PR

Closes #206

Base plots and helper/utility methods have been moved to Python_Toolkit (see the linked PR at the top)
References to python_toolkit have been made where utility and helper methods have been moved, so that the rest of the toolkit and any user scripts do not break, though plots marked private that were moved will have been updated to python_toolkit.plot.<name-of-plot> and no longer marked as private.

e.g.
from ladybugtools_toolkit.plot._heatmap import heatmap
would become
from python_toolkit.plot.heatmap import heatmap

Test files

run the python unit tests to check that nothing is broken.

Changelog

  • Moved python base plot types and some utility methods, see changelog for Python_Toolkit for more information.

Additional comments

@Tom-Kingstone Tom-Kingstone added status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement labels Nov 12, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 12, 2024
Copy link

bhombot-ci bot commented Nov 12, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

1 similar comment
Copy link

bhombot-ci bot commented Nov 12, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

@Tom-Kingstone Tom-Kingstone marked this pull request as ready for review November 13, 2024 09:52
@Tom-Kingstone Tom-Kingstone removed the status:WIP PR in progress and still in draft, not ready for formal review label Nov 13, 2024
Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

There are 20 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check unit-tests

There are 37 requests in the queue ahead of you.

@Tom-Kingstone Tom-Kingstone force-pushed the Python_Toolkit-#141-BasePlots branch from 524e6a1 to b8f9d09 Compare November 13, 2024 14:43
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with unit tests plus some self spot checks. No critical issues preventing merge. Any non-critical issues should have issues raised separately.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 3, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Dec 3, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 3, 2024

@Tom-Kingstone just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on Python_Toolkit

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 3, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 3, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check unit-tests

There are 7 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit 9dffb41 into develop Dec 3, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#141-BasePlots branch December 3, 2024 16:03
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break out plot generation into base plot types and specific implementations
2 participants