-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Python function to extract particles scraped during the last step. #5711
Merged
RemiLehe
merged 6 commits into
BLAST-WarpX:development
from
RemiLehe:particle_scraped_last_step
Feb 27, 2025
Merged
Add Python function to extract particles scraped during the last step. #5711
RemiLehe
merged 6 commits into
BLAST-WarpX:development
from
RemiLehe:particle_scraped_last_step
Feb 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed5038e
to
136e774
Compare
RemiLehe
commented
Feb 26, 2025
RemiLehe
commented
Feb 26, 2025
RevathiJambunathan
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RemiLehe for this PR!!!
I tested it and it works!
dpgrote
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
A minor change would be to have the level default to 0 which is likely the most common case.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function that extracts the particles that were scraped at the current timestep.
This is useful in callback functions, where we often want to re-inject particles that hit the boundary, and therefore need to select the ones that were scraped at the current timestep.
This also avoids calling
clear_buffer
, which potentially interferes with theBoundaryScrapingDiagnostic