db_purge: fix bugs in zlib support #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two bugs in db_purge zlib support code: 1. Wrong archive streams flushed (copy-paste programming...) 2. `Z_FULL_FLUSH` must not be used as it clears compression dictionary, this ruins compression. Use `Z_SYNC_FLUSH` instead. This fixes BOINC#3145 Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
======================================
Coverage 6.04% 6.04%
======================================
Files 36 36
Lines 5967 5967
======================================
Hits 361 361
Misses 5606 5606 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
======================================
Coverage 6.04% 6.04%
======================================
Files 36 36
Lines 5967 5967
======================================
Hits 361 361
Misses 5606 5606 |
|
Looks good - thanks for the fix. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs in db_purge zlib support code:
Z_FULL_FLUSHmust not be used as it clears compression dictionary, this ruins compression. UseZ_SYNC_FLUSHinstead.This fixes #3145
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com
Fixes #
Description of the Change
Alternate Designs
Release Notes