add default value to rms_decay and fix documentation #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffdonahue would you mind taking a look? By 'fix' documentation I really mean 'FIX' documentation. Current RMSprop in docs is completely wrong and misleading. People are writing redundant issues and PRs regarding this. |
|
So I should close #4567, then? |
|
@lukeyeager Yep |
|
Thanks @alicanb, this seems right to me. (It's definitely bad that this defaults to 0 now, didn't realize that...) |
fxbit
pushed a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
add default value to rms_decay and fix documentation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3472 and fixes #3930