Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Also display prior run results in a table #55

Closed
JeromeLeCoz opened this issue Feb 27, 2024 · 6 comments
Closed

Also display prior run results in a table #55

JeromeLeCoz opened this issue Feb 27, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@JeromeLeCoz
Copy link
Collaborator

It would be useful to complete the prior rating curve tabs in the same way as the posterior rating curve tabs (table, etc.).

@IvanHeriver
Copy link
Collaborator

Do you mean you'd like to have all the detailed resuts we have for the posterior rating curve also available for a prior rating curve?

  • the plot
  • the table
  • the equation
  • a plot of the prior distributions for each parameter
  • table with a summary of the parameters (seems a bit irrelevant for a prior run)
  • trace plots of the MC samples

Fitting all this in the current layout of a Hydraulic Configuration panel seems a bit challenging.

@JeromeLeCoz
Copy link
Collaborator Author

Not everything, just the table actually:

  • the plot: yes, as is
    
  • the table: yes, would be useful for plotting it out of the software
    
  • the equation: may not be very useful, we can skip I think
    
  • a plot of the prior distributions for each parameter: idem
    
  • table with a summary of the parameters (seems a bit irrelevant for a prior run): idem
    
  • trace plots of the MC samples: idem
    

It relates to how we could offer the possibility to compute a rating curve with no gaugings, or to use the prior RC to compute the hydrograph. I had proposed to include the prior RC in the RC list for computing the Q hydrograph, however it might be more logical to include the option "no gaugings" when creating a rating curve (I think BaM! can compute an RC with no obs, otherwise the prior RC could be taken as the posterior RC). Then we would have all the outputs of the RC available, and we could use that RC for computing the hydrograph.

@IvanHeriver
Copy link
Collaborator

This is indeed related to using no gaugings for a posterior run. I thought we has an issue on that matter but I don't seem to be able to find. A seperate issue should be opened I think.

As for the original matter of this issue, I agree with what you suggest and I'll rename the issue to "Also display prior run results in a table"

@IvanHeriver IvanHeriver changed the title Prior rating curve tabs Also display prior run results in a table Feb 28, 2024
@IvanHeriver IvanHeriver added the enhancement New feature or request label Feb 28, 2024
@IvanHeriver
Copy link
Collaborator

I'm in the process of fixing this issue. I am creating a prior result panel with the rating curve plot and the rating table (instead of only the rating curve plot). I am wondering, should I also include the "export to Bareme format" option? In the case of prior rating curves, instead of the total uncertainty, the parametric uncertainty would be used... Note that it is no extra work for me.

IvanHeriver added a commit that referenced this issue Dec 6, 2024
…ngCurveResults class

this fixes issues #55 and #81

this commit also includes some cleanup
@JeromeLeCoz
Copy link
Collaborator Author

Hello, good point. I know cases in which importing the prior RC in Bareme/Jacinthe would be useful: the gaugings may be so uncertain that we use the prior RC to check them, rather than calibrating the posterior RC with them... Some users might be confused by this option, however the risk seems low to me. So, I'd say yes, if this is no extra work. It's also convenient for comparing the prior RC and the posterior RC in Barème (even though this will be possible in future versions of BaRatinAGE).

@IvanHeriver
Copy link
Collaborator

ok, great, thanks for the answer. I consider this issue completed, then.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants