Fix overseen CLI default #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As TOML config file support was added, all default values of the CLI must be None and be moved to a default dict. This was forgotten for fail-under.
|
@Bachmann1234 sorry, I forgot this case here. Should be the only one. This bug will btw also lead to a fail-under of 0 even if set otherwise in the config file. |
|
Thanks for the fix! I'll merge now and release tonight |
|
@kasium thanks again. Released https://pypi.org/project/diff-cover/6.4.4/ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As TOML config file support was added, all default values of the CLI must be None and be moved to a default dict.
This was forgotten for fail-under.