Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade to pytest 8 #512

Merged
merged 1 commit into from
Oct 28, 2024
Merged

upgrade to pytest 8 #512

merged 1 commit into from
Oct 28, 2024

Conversation

selfisekai
Copy link
Contributor

No description provided.

@ppolewicz
Copy link
Collaborator

@selfisekai yapf would like to mess up your pretty formatting for the sake of consistency. Could you please add a # yapf: disable at the end of the affected lines to make sure your formatting is not vandalized by a bot?

Also, it appears that you've changed quotes in a bunch of lines. Do we really need to do it in this PR?

@selfisekai
Copy link
Contributor Author

i've run ruff over it, that's how it happened

@ppolewicz
Copy link
Collaborator

Please run it again on test/unit/account_info/fixtures.py with --fix

@selfisekai selfisekai force-pushed the pytest8 branch 2 times, most recently from 823accc to 850848e Compare October 28, 2024 13:43
Copy link
Contributor

@mjurbanski-reef mjurbanski-reef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pytest-lazy-fixtures library is new and unknown, so I went and checked github repo and current tar/wheel releases. They seem clean - i.e. nothing shady going in there, but before updating the lockfile similar review should be done to make sure it's not a security hazard to dev machines.

@mjurbanski-reef mjurbanski-reef merged commit 282a420 into Backblaze:master Oct 28, 2024
27 checks passed
@mlech-reef mlech-reef linked an issue Dec 16, 2024 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy-fixture is not compatible with pytest 8
3 participants