Enable flush timing to be controlled from the host. #363
Conversation
rwjblue
force-pushed
the
allow-customized-flushing
branch
2 times, most recently
from
fa627fc to
5ed02da
Compare
tests/autorun-test.ts
Outdated
| @@ -5,6 +5,14 @@ import lolex from 'lolex'; | |||
| const SET_TIMEOUT = setTimeout; | |||
| let fakeClock; | |||
|
|
|||
| function flushMicrotasks() { | |||
There was a problem hiding this comment.
isn't this flush macro task, as the promise wont resolve until setTimeout(resolve, 0)
There was a problem hiding this comment.
It’s to ensure the current event frame’s microtask queue is flushed by resolving in a macro task
There was a problem hiding this comment.
Does that make sense @stefanpenner, I can rename if you'd prefer still just give me an alternate...
There was a problem hiding this comment.
ya, I understand what it does.
The name is off, it isn’t flush microtasks, it’s wait for some near future macro task.
Nothing prevents other unexpected work from sneaking in between so the “flush” word is misleading
There was a problem hiding this comment.
happy to change it, what would you like it to be named?
Some possibilities:
escapeMicrotaskQueuestefsMagicalFutureMacroTask(😜)waitForNextMacroTask
There was a problem hiding this comment.
OK, I just renamed to escapeCurrentMicrotaskQueue which actually seems a bit more descriptive as well.
rwjblue
force-pushed
the
allow-customized-flushing
branch
2 times, most recently
from
79df7ea to
6986666
Compare
|
Fixed up linting failures and misspelling. |
* Changes `_autorun` into a boolean * Adds a new `flush` option to the backburner options which allows the host to either immediately flush (which would equal the prior behavior) via microtasks, **OR** flush "sometime later" * Adds tests to ensure execution order Co-authored-by: Kris Selden <kris.selden@gmail.com>
rwjblue
force-pushed
the
allow-customized-flushing
branch
from
6986666 to
a29d59e
Compare
_autoruninto a booleanflushoption to the backburner options which allows the host to either immediately flush (which would equal the prior behavior) via microtasks, OR flush "sometime later"Paired with @krisselden