Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cherry pick fix to Electron.NativeImage icon argument #2

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

julienma
Copy link
Member

@julienma julienma commented Jun 5, 2019

Reimplement max-mapper#198.

@julienma
Copy link
Member Author

julienma commented Jun 5, 2019

Might also need to use NativeImage instead of path when called from CashNotify.
See electron/electron#9795 (comment).

@julienma julienma merged commit e9d0a43 into master Jun 5, 2019
@julienma julienma deleted the fix/electron-nativeimage branch June 5, 2019 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant