OpenIssue #581Handling PermissionRequestInProgressException on iOS fixed #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
Dolar1
reviewed
Sep 28, 2023
| @@ -54,7 +54,6 @@ - (void) requestPermission:(PermissionConfirmation)confirmationHandler | |||
| // Permission request is already running, return immediatly with error | |||
| errorHandler(GeolocatorErrorPermissionRequestInProgress, | |||
| @"A request for location permissions is already running, please wait for it to complete before doing another request."); | |||
| return; | |||
There was a problem hiding this comment.
Tried removing return and giving local ref in yaml but it still get's produced.
|
Closing this PR as this is not the correct way to resolve the issue. The error is caused when people dismis the permission dialog or put the application in the background while the permission dialog is showing. Unfortunately the iOS doesn't inform the geolocator (nor any other application) that the dialog is dismissed and therefore the geolocator keeps the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
It return is removed from the ios native permissionhandle.m
🆕 What is the new behavior (if this is a feature change)?
In the permission request the popup appears and once the mobile locked then the popup disappear and the click will not do anything(thing is the await function waiting for the response from popup but the popup disappear(it is default iOS fn).
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
#581
🤔 Checklist before submitting
master.