Skip to content

Fixed warnings from publication dry-run #15

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 22, 2018

Conversation

mvanbeusekom
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Running flutter packages pub publish --dry-run results in a list with warning that should be solved.

🆕 What is the new behavior (if this is a feature change)?

Solved the warnings shown after running flutter packages pub publish --dry-run

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Rebased onto current develop

spockfish
spockfish previously approved these changes Jun 22, 2018
@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #15 into develop will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #15      +/-   ##
===========================================
- Coverage    94.11%   93.93%   -0.18%     
===========================================
  Files            2        2              
  Lines           34       33       -1     
===========================================
- Hits            32       31       -1     
  Misses           2        2
Impacted Files Coverage Δ
lib/geolocator.dart 80% <100%> (-1.82%) ⬇️
lib/models/position.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df5877...a149be7. Read the comment docs.

@mvanbeusekom mvanbeusekom merged commit a7374e1 into develop Jun 22, 2018
@mvanbeusekom mvanbeusekom deleted the bug/fix_publishing_requirements branch June 22, 2018 13:30
@martijn00 martijn00 added this to the 1.0 milestone Jul 31, 2018
@FalkF FalkF mentioned this pull request Jun 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants