Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[geolocator_android] Resolves ./gradlew build issue #1593

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

arrrrny
Copy link

@arrrrny arrrrny commented Oct 19, 2024

When I ran ./gradlew clean
./gradlew build

I was getting below error. This PR fixes the build issue.

> Task :geolocator_android:lintDebug FAILED
Lint found 1 errors, 6 warnings. First failure:

/Users/altezza/.pub-cache/hosted/pub.dev/geolocator_android-4.6.1/android/src/main/java/com/baseflow/geolocator/location/BackgroundNotification.java:100: Error: Missing permissions required by NotificationManagerCompat.notify: android.permission.POST_NOTIFICATIONS [MissingPermission]
            notificationManager.notify(notificationId, builder.build()

Pre-launch Checklist

  • I made sure the project builds.
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Screenshot 2024-10-19 at 8 33 01 AM

fixes lint issue when ./gradlew ran
bumped version
fixes Missing permissions required by NotificationManagerCompat.notify: android.permission.POST_NOTIFICATIONS [MissingPermission]
upgraded geolocator_android version to 4.6.1
resolved build issue on ./gradlew 8.4
bumped version to 4.6.2
@arrrrny arrrrny changed the title [fix] Resolves ./gradlew build issue [geolocator_android] Resolves ./gradlew build issue Oct 19, 2024
Copy link

@TitanKing TitanKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good way to get passed this annoying issue for people with newer versions of gradle restrictions.

@DurgeshSawantWYLD
Copy link

Facing the same issue, please merge this with main flutter geolocator branch. Thanks in advance

@MyBlueford16
Copy link

@arrrrny @TitanKing , will this be able to be merged in soon? it's a bit of a blocker for me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants