Skip to content

Added instructions on using Swift plugin in ObjC App #19

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

mvanbeusekom
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Docs update

⤵️ What is the current behavior?

There are some problems when adding a Swift plugin into a Objective-C App. Instructions on how to workaround this problem are missing.

🆕 What is the new behavior (if this is a feature change)?

Added instructions on how to work around the problem of using a Swift plugin in a Objective-C App.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

n/a

📝 Links to relevant issues/docs

Flutter#16049

🤔 Checklist before submitting

  • All projects build
  • Rebased onto current develop

Copy link
Contributor

@spockfish spockfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De zin loopt niet helemaal.

There's a known issue with integrating plugins that use Swift.

@codecov-io
Copy link

Codecov Report

Merging #19 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #19   +/-   ##
========================================
  Coverage    93.93%   93.93%           
========================================
  Files            2        2           
  Lines           33       33           
========================================
  Hits            31       31           
  Misses           2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1d950...9538ad7. Read the comment docs.

@martijn00 martijn00 merged commit 10797af into develop Jun 29, 2018
@martijn00 martijn00 added this to the 1.0 milestone Jul 31, 2018
@FalkF FalkF mentioned this pull request Jun 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants