Support to supply desired accuracy #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
reviewed
Aug 1, 2018
| public void onListen(Object o, EventChannel.EventSink eventSink) { | ||
| if (mStreamLocationService != null) { | ||
| eventSink.error( | ||
| "ALLREADY_LISTENING", |
There was a problem hiding this comment.
[nit] Spelling error ALLREADY -> ALREADY.
| "Access to location data denied. To allow access to location services enable them in the device settings.", | ||
| null)); | ||
| public void onCompletion(UUID taskID) { | ||
| Iterator<Map.Entry<UUID, Result>> it = mResultHandles.entrySet().iterator(); |
| mEventSink.error("PERMISSION_DENIED", "Access to location data denied", null); | ||
| mEventSink = null; | ||
| } | ||
| if (taskID == entry.getKey()) { |
There was a problem hiding this comment.
Should use .equals instead. Otherwise you are comparing object references.
| SignalResultHandles((result) -> result.error("ERROR", "Failed to get location.", null)); | ||
| try { | ||
| int index = (Integer) o; | ||
| if(index > 0 && index < GeolocationAccuracy.values().length) { |
There was a problem hiding this comment.
That should probably be if(index >= 0 && ...
2 tasks
1 task
2 tasks
1 task
2 tasks
This was referenced Aug 14, 2024
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature (resolves #1 )
Currently it is not possible to supply a desired accuracy, possible resulting in high battery use.
🆕 What is the new behavior (if this is a feature change)?
It is now possible to supply a desired accuracy when requesting the position.
💥 Does this PR introduce a breaking change?
Yes (see CHANGELOG.md)
🐛 Recommendations for testing
Run unit-tests:
flutter test(or check results from Travis-CI)📝 Links to relevant issues/docs
Resolves #1
🤔 Checklist before submitting