Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renamed project from 'flutter_geolocator' to 'geolocator' #7

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

mvanbeusekom
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Refactoring

⤵️ What is the current behavior?

Project name is wrong

🆕 What is the new behavior (if this is a feature change)?

Renamed the project from FlutterGeolocator to Geolocator

💥 Does this PR introduce a breaking change?

Yes (but since nothing is in production this is not a big deal)

🐛 Recommendations for testing

Run unit-test: flutter test

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Rebased onto current develop

@mvanbeusekom mvanbeusekom requested a review from martijn00 June 11, 2018 15:19
@codecov-io
Copy link

Codecov Report

Merging #7 into develop will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #7   +/-   ##
========================================
  Coverage    94.44%   94.44%           
========================================
  Files            2        2           
  Lines           36       36           
========================================
  Hits            34       34           
  Misses           2        2
Impacted Files Coverage Δ
lib/geolocator.dart 84.61% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ab688...bcbfdf1. Read the comment docs.

@martijn00 martijn00 merged commit 3ee7c74 into develop Jun 11, 2018
@martijn00 martijn00 added this to the 1.0 milestone Jul 31, 2018
@DineshKachhot DineshKachhot mentioned this pull request Dec 13, 2018
2 tasks
@FalkF FalkF mentioned this pull request Jun 9, 2019
@Abdullah2050 Abdullah2050 mentioned this pull request Oct 3, 2019
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants