Fix issue #26 #182

ty0x2333 · 2019-12-26T05:24:48Z

I used this library in my application. But when I submitted the application to the app store for review, I received a warning email. same as #26.

I see in README that "on iOS you will have to include all permission options when you want to submit your app". This makes this library almost impossible to use on iOS.

I added some macro definitions to remove useless permissions. (reference: https://github.com/delba/permission)

This PR will not change any default behavior.

By default, these macro definitions do not exist, and the code will default that they are enabled. Unless the user specifies their value in the Podfile.

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

⤵️ What is the current behavior?

same as before

🆕 What is the new behavior (if this is a feature change)?

Users can remove unused permission codes on iOS.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Usage: 296982b

📝 Links to relevant issues/docs

#26

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated
Rebased onto current develop

SpajicM · 2019-12-30T10:26:08Z

Finally a proper fix for this! Thanks!

mvanbeusekom

@ty0x2333 thank you very much for this PR it looks very good. Sorry for the late reply, I was on holiday during the festive season.

I do have one small remark which is related to the documentation, please have a look.

README.md

mvanbeusekom · 2020-01-06T08:38:25Z

Resolves: #26
Resolves: #179

mvanbeusekom

Thank you, this looks great.

jikeyt · 2020-01-09T11:42:51Z

@ty0x2333 I need only camera and photos permission. I added the following code in the podfile, excluded those two, cleaned and rebuilt. But once uploaded to TestFlight, I'm still getting the error. Am I missing something? PFA.

mvanbeusekom · 2020-01-10T14:54:54Z

@jikeyt just checking the obvious, which version of the plugin are you using? This feature is not yet released to pub and should only work if you reference the develop branch (or the fork from @ty0x2333).

mvanbeusekom · 2020-01-10T19:06:01Z

We just (5 minutes ago) released version 4.1.0 which contains the contents of this PR.

ramoncardena · 2020-01-25T18:38:07Z

Thanks so much for this fix @ty0x2333!

brunozanoelo · 2020-07-08T12:28:27Z

Hello @mvanbeusekom. I´m developin with flutter for Android and iOS, I don´t have any Podfile on my project, because I use windows. Where should I change those permission? Thank you.

mvanbeusekom · 2020-07-08T15:30:32Z

Hi @brunozanoelo, if you want to develop for iOS you will have to compile your project on a Apple machine running macOS, there is no escaping to this. So if you stick to Windows you will not be able to develop the iOS App (or at least compile it). In this case you will only be able to develop for Android and the web (and in the near future Windows and Linux Desktop).

Most likely Flutter noticed you are running on Windows when you initially created your project and didn't setup the iOS part of the project (in your project root there should be an ios folder is you want to release to iOS, this is also the folder that would contain the Podfile file).

In your case there will not be an iOS App and thus no need to worry about the permission configuration yet. Once you get hold of a Apple machine with macOS and Xcode you will be able to generate the iOS part of the Flutter project and you will automatically also have a Podfile.

brunozanoelo · 2020-07-09T19:02:14Z

Hello @mvanbeusekom, Thank you for you reply.

I don´t have an mac computer, so I´m building this with Codemagic, with him, I´m able to build and automatically publish into Play Store and Apple Store. However, the changes to run the app inside Podfile is very difficult for me, since I need to access the cloud machine pretty fast and change the Podfile everytime I build one version, and actually, this is not working so far.

It seens, I´m the different one, but buying one macOS will be pretty expensive in my country.

SpajicM · 2020-07-09T19:33:08Z

@brunozanoelo I've used MacInCloud to do iOS specific things, it's pretty cheap if you only need it for a couple of days, and first 24h were free.

noordawod · 2022-06-08T08:29:18Z

README.md

-> IMPORTANT: On iOS you will have to include all permission options when you want to submit your App. This is because the `permission_handler` plugin touches all different SDKs and because the static code analyser (run by Apple upon App submission) detects this and will assert if it cannot find a matching permission option in the `Info.plist`. More information about this can be found [here](https://github.com/Baseflow/flutter-permission-handler/issues/26). Unfortunately we don't have a good solution for this.    
+> IMPORTANT: ~~On iOS you will have to include all permission options when you want to submit your App.~~ This is because the `permission_handler` plugin touches all different SDKs and because the static code analyser (run by Apple upon App submission) detects this and will assert if it cannot find a matching permission option in the `Info.plist`. More information about this can be found [here](https://github.com/BaseflowIT/flutter-permission-handler/issues/26).
+
+On iOS, the permission_handler plugin use [macros](https://github.com/BaseflowIT/flutter-permission-handler/blob/develop/ios/Classes/PermissionHandlerEnums.h) to control whether a permission is supported.


This URL is no longer valid. Any chance to submit a pr to correct it?

noordawod · 2022-06-08T08:29:57Z

README.md

+
+On iOS, the permission_handler plugin use [macros](https://github.com/BaseflowIT/flutter-permission-handler/blob/develop/ios/Classes/PermissionHandlerEnums.h) to control whether a permission is supported.
+
+By default, all the permissions listed [here](https://github.com/Baseflow/flutter-permission-handler#list-of-available-permissions) are supported.


This URL is no longer valid. Any chance to submit a pr to correct it?

noordawod · 2022-06-08T08:30:14Z

README.md

+>          ... # Here are some configurations automatically generated by flutter
+>    
+>          # You can remove unused permissions here
+>          # for more infomation: https://github.com/BaseflowIT/flutter-permission-handler/blob/develop/ios/Classes/PermissionHandlerEnums.h


This URL is no longer valid. Any chance to submit a pr to correct it?

noordawod · 2022-06-08T08:32:01Z

example/ios/Podfile

@@ -64,6 +64,47 @@ post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
+
+      # You can remove unused permissions here
+      # for more infomation: https://github.com/BaseflowIT/flutter-permission-handler/blob/develop/ios/Classes/PermissionHandlerEnums.h


This URL is no longer valid. Any chance to submit a pr to correct it?

ty0x2333 added 3 commits December 26, 2019 12:23

Add macro definition in iOS code to remove useless permissions.

e0d108d

Add configuration example to Podfile

296982b

Update README.md

770fac4

This was referenced Dec 26, 2019

Apple rejects all binaries built using this package, unless ALL permissions have purposes/reasons added in the .plist, even if the app is not using most of them... #26

Closed

Apple rejecting my app because of extra permissions #179

Closed

mvanbeusekom requested changes Jan 6, 2020

View reviewed changes

README.md Show resolved Hide resolved

mvanbeusekom added this to the 4.1.0 milestone Jan 6, 2020

mvanbeusekom and others added 2 commits January 6, 2020 09:39

Merge branch 'develop' into ios_permission_selectivity

20606c7

Update README

87a5978

mvanbeusekom previously approved these changes Jan 6, 2020

View reviewed changes

Update README

b9f9e4b

ty0x2333 dismissed mvanbeusekom’s stale review via b9f9e4b January 6, 2020 09:59

mvanbeusekom approved these changes Jan 6, 2020

View reviewed changes

mvanbeusekom merged commit a1b96e6 into Baseflow:develop Jan 6, 2020

noordawod reviewed Jun 8, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue #26 #182

Fix issue #26 #182

ty0x2333 commented Dec 26, 2019

SpajicM commented Dec 30, 2019

mvanbeusekom left a comment

mvanbeusekom commented Jan 6, 2020

mvanbeusekom left a comment

jikeyt commented Jan 9, 2020

mvanbeusekom commented Jan 10, 2020

mvanbeusekom commented Jan 10, 2020

ramoncardena commented Jan 25, 2020

brunozanoelo commented Jul 8, 2020 •

edited

Loading

mvanbeusekom commented Jul 8, 2020 •

edited

Loading

brunozanoelo commented Jul 9, 2020 •

edited

Loading

SpajicM commented Jul 9, 2020

noordawod Jun 8, 2022

noordawod Jun 8, 2022

noordawod Jun 8, 2022

noordawod Jun 8, 2022


		On iOS, the permission_handler plugin use [macros](https://github.com/BaseflowIT/flutter-permission-handler/blob/develop/ios/Classes/PermissionHandlerEnums.h) to control whether a permission is supported.

		By default, all the permissions listed [here](https://github.com/Baseflow/flutter-permission-handler#list-of-available-permissions) are supported.

Fix issue #26 #182

Fix issue #26 #182

Conversation

ty0x2333 commented Dec 26, 2019

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

SpajicM commented Dec 30, 2019

mvanbeusekom left a comment

Choose a reason for hiding this comment

mvanbeusekom commented Jan 6, 2020

mvanbeusekom left a comment

Choose a reason for hiding this comment

jikeyt commented Jan 9, 2020

mvanbeusekom commented Jan 10, 2020

mvanbeusekom commented Jan 10, 2020

ramoncardena commented Jan 25, 2020

brunozanoelo commented Jul 8, 2020 • edited Loading

mvanbeusekom commented Jul 8, 2020 • edited Loading

brunozanoelo commented Jul 9, 2020 • edited Loading

SpajicM commented Jul 9, 2020

noordawod Jun 8, 2022

Choose a reason for hiding this comment

noordawod Jun 8, 2022

Choose a reason for hiding this comment

noordawod Jun 8, 2022

Choose a reason for hiding this comment

noordawod Jun 8, 2022

Choose a reason for hiding this comment

brunozanoelo commented Jul 8, 2020 •

edited

Loading

mvanbeusekom commented Jul 8, 2020 •

edited

Loading

brunozanoelo commented Jul 9, 2020 •

edited

Loading