Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update of barbuk theme (add modular blocks) #2121

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Mar 9, 2022

Description

This is a complete rework of my theme.

Motivation and Context

I'm using more tools at work or for personal usage that need context in my shell:

  • ruby version
  • terraform
  • aws / scw profil

The theme is the same, but with more flexibility.
You can now configure it to display different information by setting BARBUK_PROMPT env variable.

How Has This Been Tested?

All new block are inspired from base theme or powerline theme.
I use the theme to work, it's was tested in real work condition :).

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@BarbUk BarbUk force-pushed the update/theme_barbuk branch from 4929f38 to 9a71556 Compare March 9, 2022 21:04
@BarbUk
Copy link
Contributor Author

BarbUk commented Mar 10, 2022

Just a precision:

  • Theme display does not change
  • The rework is only to make it more customizable / modular

@BarbUk BarbUk changed the title Complete rework of barbuk theme Update of barbuk theme (add configurable blocks) Apr 7, 2022
@BarbUk BarbUk changed the title Update of barbuk theme (add configurable blocks) Update of barbuk theme (add modular blocks) Apr 7, 2022
@BarbUk
Copy link
Contributor Author

BarbUk commented Apr 7, 2022

I changed the title to make it less scary :)

The major thing is:

  • if people are using this theme, it will not change after update
  • the theme is now modular and can be configured with BARBUK_PROMPT env.
BARBUK_PROMPT="git-uptream-remote-logo ssh path scm python_venv ruby node terraform cloud duration exit"

Feedback and review are welcome.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for contributing @BarbUk !

@NoahGorny NoahGorny merged commit 35334cd into Bash-it:master Apr 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants