Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upgrade the sphinx version #2145

Merged
merged 2 commits into from
May 7, 2022
Merged

Upgrade the sphinx version #2145

merged 2 commits into from
May 7, 2022

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented May 6, 2022

Description

This pull request fixed the sphinx-build here

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

NoahGorny
NoahGorny approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs @tbhaxor !

@NoahGorny NoahGorny merged commit 4dddba3 into Bash-it:master May 7, 2022
@tbhaxor
Copy link
Contributor Author

tbhaxor commented May 7, 2022

Hey @NoahGorny why these tests on macos keeps on failing. I though u alread fixed that

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbhaxor @NoahGorny