bug:CI Lint - Install shellcheck via wget #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs shellcheck via wget of github release for 'stable' linux version
davidpfarrell
force-pushed
the
bug/ci-lint
branch
from
2d0a9a7 to
54b1281
Compare
davidpfarrell
changed the title
cornfeedhobo
approved these changes
Oct 30, 2022
|
Thank you! |
cevhyruz
added a commit
to cevhyruz/dotfiles
that referenced
this pull request
Feb 3, 2023
douglasjacobsen
added a commit
to douglasjacobsen/bash-it
that referenced
this pull request
Jan 19, 2024
* upstream/master: (1190 commits) Add support to powerline themes to override foreground color (Bash-it#2231) ci: Update GitHub actions v2 => v4 (Bash-it#2224) docs: Update Bats libraries links (Bash-it#2225) fix: bumps go version to 1.21.0 and changes go get to go install [terraform] add alias for terraform workspace fix (completion): suppress 1091 in brew (Bash-it#2130) Allow for longer command min duration (Bash-it#2198) Implement yarn completion (Bash-it#2190) Fix lint errors in multiple files (Bash-it#2192) bug: Use C style strings when checking for invalid alias characters (Bash-it#2188) Remove libra chat reference Add more aliases for `git branch`, use long form remove function wrapper around kubectl alias registration bug: Use en_US when fetching EPOCHREALTIME bug:Install shellcheck wget (Bash-it#2173) fix(theme): use correct escape sequence to avoid weird text overwriting chore: Use grep -E / grep -F instead of egrep / fgrep (Bash-it#2164) Fixed broken code blocks in troubleshooting.rst Removed Bash Dependency section from README and added it to troubleshooting.rst Update variable name to match projects.plugin.bash ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breaking 'lint' ci job
Description
replaces use of
brewwhen installing shellcheck.Now fetches pre-compiled stable linux version from project's github releases
Motivation and Context
Brew stopped being installed by default on github ubuntu images, breaking the ability to use it to install shellcheck.
How Has This Been Tested?
This PR's lint pipeline task runs successfully !
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.