-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
staging-causality (explainable reasoning as a separate module) #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added preempt and its tests * refactored test to use new code * lint * added consequent_differs and a test thereof --------- Co-authored-by: eb8680 <eb8680@users.noreply.github.com>
* added preempt and its tests * refactored test to use new code * lint * added Preemptions and a test thereof * added `undo_split` and a test thereof (#422) * import --------- Co-authored-by: Eli <eli@elibingham.com>
* added preempt and its tests * refactored test to use new code * lint * added Preemptions and a test thereof * added `undo_split` and a test thereof * added SplitSubsets and a test thereof * added `undo_split` and a test thereof (#422) * import --------- Co-authored-by: Eli <eli@elibingham.com> Co-authored-by: eb8680 <eb8680@users.noreply.github.com>
* docstrings update WIP * small typo
* add soft_neq and a few tests in test_ops * sof eq WIP * conversion to soft_eq * defaulting soft_eq scale to .1 * Tavares conditions have landed * soft_neq with tests * added docstring for soft_neq * refactor soft_eq and soft_neq * tests * remove failing tests * comment * sign * move soft_neq to internals for now * nit * remove comment --------- Co-authored-by: Eli <eli@elibingham.com>
* Add explainable module to sphinx build * Add explainable module to sphinx build
* Add explainable module to sphinx build * Add explainable module to sphinx build * reorganize codebase * remove empty file * rename alternatives * reorganize test files * sphinx * remove test_defaults
* that's it * lint * lint * preemptions type as required by runner lint * persistent lint typing error, using Any * reverting to Preemptions
* added `random intervention` and a test thereof * added `SearchForExplanation` and a test thereof * added ac notebook with a test * small cleanup * that's it * rerun actual causality and added it to rst * actual causality nb WIP * lint * proofreading * lint * preemptions type as required by runner lint * persistent lint typing error, using Any * reverting to Preemptions * lint, add actual_causality to notebook tests again * removed redundant alternatives.py * remove redundant split_subset.py * fixing docstrings * format & lint * pulled explanation from ru-propagate-... * docstrings in explanation.py * typo in ac nb --------- Co-authored-by: eb8680 <eb8680@users.noreply.github.com>
* allow for empty witness in SearchForCause * removed mwc_empty from a test * allow empty ant and con
This was referenced Jan 12, 2024
eb8680
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is stable enough now to land on master
.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the staging scene for the explainable reasoning module.